Fix issue with filter plus serialization #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See discussion in #174. The issue was related to whether or not filter should return a list or an element... that should depend on if a single element was filtered to or not.
Codecov Report
@@ Coverage Diff @@
## master #177 +/- ##
==========================================
- Coverage 27.23% 27.17% -0.07%
==========================================
Files 13 13
Lines 2122 2131 +9
==========================================
+ Hits 578 579 +1
- Misses 1544 1552 +8
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion in #174. The issue was related to whether or not filter
should return a list or an element... that should depend on if a single
element was filtered to or not.