Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'characters' is deprecated: Please use String or Substring directly #163

Closed
alexleeelkins opened this issue Nov 6, 2017 · 4 comments
Closed

'characters' is deprecated: Please use String or Substring directly #163

alexleeelkins opened this issue Nov 6, 2017 · 4 comments

Comments

@alexleeelkins
Copy link

Line 419 of SWXMLHash+TypeConversion.swift should be replaced with
if !textVal.isEmpty {
drmohundro added a commit that referenced this issue Nov 6, 2017
@drmohundro
Fix characters deprecation
c320f1d 
Fixes #163
@drmohundro drmohundro mentioned this issue Nov 6, 2017
Merged
@drmohundro
Copy link
Owner

Done! Let me know if you need a point release tagged for this, too.

@jpsim
Copy link
Contributor

jpsim commented Nov 9, 2017

I'd appreciate a release tag for this 🙏

@drmohundro
Copy link
Owner

👍 just pushed 4.2.4

@jpsim
Copy link
Contributor

jpsim commented Nov 9, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@drmohundro @jpsim @alexleeelkins