[feat] inArray and notInArray accept empty list #2502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make inArray and notInArray methods accept an empty list as their second parameter
RemiPeruto
force-pushed
the
feat/allow-empty-list-for-in-array-and-not-in-array
branch
from
fc80d21
to
a50ebc3
Compare
|
@philippdormann You reviewed the same changes back in march of this year in the MR #1664 |
|
@RemiPeruto @AndriiSherman This PR would actually fix an issue in my project, could you review it please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1295
Make inArray and notInArray methods accept an empty list as their second parameter instead of throwing an error :
the comment referencing the choice of implementation in the thread