-
-
Notifications
You must be signed in to change notification settings - Fork 782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Missing link/section about sync and async APis for sqlite #1552
Comments
@vlad-stohnii looks to be the author according to the blame. Do you remember where it was supposed to link to? 🙏 |
I saw the missing link in the docs site and wanted to contribute a quick pull request to add it. However, that led me down a rabbit hole - apparently async API for SQLite is still an unsolved question. It was originally added here: But currently
This mismatch (?) of wrapping the synchronous interface of SQLite with an async API seems to be the cause of an issue with transaction rollback.
Someone wrote a workaround for that particular issue, but it does seem like this topic deserves its own section in the documentation. This page in the SQLite docs gets to the heart of the matter, describing the tradeoffs of sync/async interface.
|
@AndriiSherman @eliot-akira Is there any update to this? |
The original issue description is out of date now, these mentioned links don't exist anymore:
Searching the docs, there is a mention of an async API for SQLite, still without a link.
From what I can see, the solution may be a big effort.
|
It seems that libsql supports async transactions drizzle-orm/drizzle-orm/src/libsql/session.ts Lines 141 to 148 in 04c9143
|
I see, a few lines above it, there is a comment:
Also noticed in drizzle-orm/drizzle-orm/src/op-sqlite/session.ts Lines 86 to 94 in 04c9143
|
This is a project so many depend on and the code is insanely weird and unmaintained. I hope transactions work with libsql otherwise a lot of work is wasted Edit: It seems that drizzle support async transaction with libsql |
At the end of these pages https://orm.drizzle.team/docs/quick-sqlite/bun and https://orm.drizzle.team/docs/quick-sqlite/better-sqlite3 there's this paragraph:
The link (or the following section) appear to be missing.
The text was updated successfully, but these errors were encountered: