Skip to content

adding xgboost to dependencies#6

Merged
r-b-g-b merged 2 commits into
drivendataorg:mainfrom
Traava:main
Apr 13, 2022
Merged

adding xgboost to dependencies#6
r-b-g-b merged 2 commits into
drivendataorg:mainfrom
Traava:main

Conversation

@Traava

@Traava Traava commented Apr 12, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@r-b-g-b r-b-g-b self-requested a review April 13, 2022 13:46
@r-b-g-b

r-b-g-b commented Apr 13, 2022

Copy link
Copy Markdown
Collaborator

@Traava thanks for the PR. It looks like conda-forge does not yet have xgboost 1.5.2 (the latest is 1.5.1). We have a couple options:

  1. Install 1.5.1 from conda-forge. This is preferred.
  2. Install 1.5.2 from PyPI using pip. If you require 1.5.2, we can try pip. Fair warning that pip installs can lead to trouble; pip might decide to downgrade packages that conda installs. In that case, we'd have to do some work to make sure the new environment is still compatible with the previous submissions.

@Traava

Traava commented Apr 13, 2022

Copy link
Copy Markdown
Contributor Author

Changing xgboost version to allow merge

@r-b-g-b r-b-g-b merged commit 1383a01 into drivendataorg:main Apr 13, 2022
@r-b-g-b

r-b-g-b commented Apr 13, 2022

Copy link
Copy Markdown
Collaborator

Thanks! xgboost should be available in the submission runtime within the hour.

@s-t-mcdonald

Copy link
Copy Markdown

Hi @r-b-g-b , I am working with Traava on the project. I just made the most recent pull from the docker hub. It seems somehow the new container has messed up the supervisor.py script. This is the new error I get whenever I run the benchmark src. Do you know what may be causing this. As far as I can tell, the only change would be the addition of xgboost as a dependency, but I do not see how it affects this.

Traceback (most recent call last):
File "/supervisor/supervisor.py", line 9, in
import typer
File "/srv/conda/envs/nasa-airport-config-runtime/lib/python3.9/site-packages/typer/init.py", line 12, in
from click.termui import get_terminal_size as get_terminal_size
ImportError: cannot import name 'get_terminal_size' from 'click.termui' (/srv/conda/envs/nasa-airport-config-runtime/lib/python3.9/site-packages/click/termui.py)
ERROR conda.cli.main_run:execute(41): conda run python /supervisor/supervisor.py 2021-10-16T00:00:00 failed. (See above for error)
make: *** [Makefile:94: test-submission] Error 1

@r-b-g-b

r-b-g-b commented Apr 13, 2022

Copy link
Copy Markdown
Collaborator

Hi @s-t-mcdonald ,

Can you post the commands I can use to reproduce this? I have seen this kind of error between typer and click versions, so hopefully it will be a quick fix. It is surprising to me that just adding xgboost would cause this, but stranger things have happened.

Probably related to fastapi/typer#375

@s-t-mcdonald

Copy link
Copy Markdown

Thanks for the fast response! @r-b-g-b

All I did was clear out all previous docker images, and then did
sudo make pull
sudo make pack-benchmark
sudo make test-submission

@r-b-g-b

r-b-g-b commented Apr 13, 2022

Copy link
Copy Markdown
Collaborator

Great, I was able to reproduce that. Working on a fix now, should be available shortly! Thanks for letting me know.

@r-b-g-b

r-b-g-b commented Apr 13, 2022

Copy link
Copy Markdown
Collaborator

@s-t-mcdonald Appears to be working now, let me know if you have any other trouble!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants