-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make prefix not being recognised as dirs anymore #244
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @frndmg! We have to get this onto a branch rather than a fork to do the live tests, but lets make the updates here for the tests first.
@pjbull, thanks for your review! Now testing for mocked backend and using already uploaded files. Let me know if there is anything else that needs to be adjusted 👍 Feel free to push this to a local branch 👍 |
Thanks @frndmg! Once CI passes here, I'll pull over to a local branch to run the tests against live servers |
Actually, would you mind adding a note in the HISTORY.md as well? I believe you need to start a new "unreleased" section. Here's an old one for reference: Lines 3 to 5 in 85268c8
|
@pjbull feel free to update the message in the |
Codecov Report
@@ Coverage Diff @@
## 244-cloud-tests #244 +/- ##
=================================================
- Coverage 95.0% 94.4% -0.6%
=================================================
Files 21 21
Lines 1323 1324 +1
=================================================
- Hits 1257 1251 -6
- Misses 66 73 +7
|
* make prefix not being recognised as dirs anymore * update tests * remove unnecessary fixture * update history Co-authored-by: Fernando <[email protected]>
Fixes #208