-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement content type propagation #226
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
72277c3
to
6083928
Compare
Codecov Report
@@ Coverage Diff @@
## master #226 +/- ##
========================================
- Coverage 94.8% 94.7% -0.2%
========================================
Files 21 21
Lines 1256 1287 +31
========================================
+ Hits 1191 1219 +28
- Misses 65 68 +3
|
d254348
to
6fb75b1
Compare
jayqi
requested changes
May 18, 2022
Thanks @jayqi for review! Integrated all your comments. |
jayqi
approved these changes
May 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, aside from small typo. I think you can bump the version in setup.py and then release after merging.
Co-authored-by: Jay Qi <[email protected]>
Co-authored-by: Jay Qi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements propagating content types to all of the cloud providers. Does so by adding a kwarg to all clients
content_type_method
that by default is set to the built-inmimetypes.guess_type
.Includes tests and documentation.
Changes looks bigger than it is because all of our Local testing resources and Mocks had to be updated to track content types that were set so that we could test them.
Closes #222