Add ability to set endpoint_url from AWS_ENDPOINT_URL env variable #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ery useful for localstack while waiting for upstream PR from boto3: boto/boto3#2746
|
Looks good to me! Test would be great, and then an issue to track removing if/when the upstream issue is resolved. |
Codecov Report
@@ Coverage Diff @@
## master #193 +/- ##
========================================
- Coverage 94.3% 93.9% -0.5%
========================================
Files 21 21
Lines 1197 1198 +1
========================================
- Hits 1129 1125 -4
- Misses 68 73 +5
|
added 2 commits
January 25, 2022 10:26
|
Here's that test |
|
Added the issue as well |
|
Test looks good. Can you make sure linting passes? ( |
|
Done, not sure why the live tests would be failing though. Doesn't seem to be related to this change. |
|
@kabirkhan yeah, i think that is just that PRs from forks can't use the secrets so live tests can't authenticate. i'll do some digging to see how we enable that. |
|
Dropped these changes on their own branch so we can run the live tests there to confirm |
pjbull
added a commit
that referenced
this pull request
Jan 26, 2022
) (#195) * Add ability to set endpoint_url from AWS_ENDPOINT_URL env variable. Very useful for localstack while waiting for upstream PR from boto3: boto/boto3#2746 * add test * rm print * lint Co-authored-by: Kabir Khan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys! Long time :)
Loving this package so far. One minor convenience that might be easier to merge here than this ridiculous upstream PR for the boto3 library.
Allows setting the endpoint_url from the AWS_ENDPOINT_URL env variable while waiting for the upstream PR from boto3: boto/boto3#2746
I'll add a test if the idea works for you guys