Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support TransferConfig for s3 uploads and downloads #150

Merged
merged 10 commits into from
Jul 5, 2021

Conversation

ejm714
Copy link
Contributor

@ejm714 ejm714 commented Jul 2, 2021

Adds the ability to specify boto3.s3.transfer.TransferConfig parameters, which is useful for controlling multipart and thread use in uploads and downloads.

Outstanding:

  • test coverage

Closes #147

@ejm714 ejm714 requested a review from pjbull July 2, 2021 21:16
@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2021

@codecov
Copy link

codecov bot commented Jul 2, 2021

Codecov Report

Merging #150 (3942ac7) into master (25ff783) will increase coverage by 0.0%.
The diff coverage is 100.0%.

@@          Coverage Diff           @@
##           master    #150   +/-   ##
======================================
  Coverage    93.9%   93.9%           
======================================
  Files          21      21           
  Lines        1177    1179    +2     
======================================
+ Hits         1106    1108    +2     
  Misses         71      71           
Impacted Files Coverage Δ
cloudpathlib/s3/s3client.py 93.1% <100.0%> (+0.1%) ⬆️

@pjbull
Copy link
Member

pjbull commented Jul 5, 2021

@ejm714 Got a "live" test running with the code that you provided. Here's the diff if you are curious:
https://github.com/drivendataorg/cloudpathlib/pull/150/files/eee669a01883f61fd4199234cda183bb9a5fe22f..3942ac70e3d9e78d446efa0ac5d4cfbf13af3059

  • Bonus fix: give the test rigs a live_server flag so that we can branch within tests if necessary (like for this one).

I think this is ready to merge, thanks!

@pjbull pjbull merged commit 80f7afd into master Jul 5, 2021
@pjbull pjbull deleted the 147-transfer-config branch February 6, 2022 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow passing a TransferConfig to control upload/download configuration for S3
2 participants