Google Cloud Storage Support #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
January 5, 2021 07:44
|
This is awesome, thanks @wolfgangwazzlestrauss! We'll take a more detailed look, but I think I've added all the creds we need as secrets in GitHub actions. Can you add the action to authenticate to google cloud to the tests workflow: I've set the two secrets mentioned there, so I think you should also remove (I've also created a test bucket and set it as the |
jayqi
pushed a commit
that referenced
this pull request
Jan 24, 2021
* Google Cloud Storage Support (#113) * Update README and imports for Google Cloud Storage * Write Google Storage download and upload methods * Change key to blob for GSClient * Implement pass methods for GSClient * Write live tests for GSClient and GSPath * Unify GSClient methods * Add Mock Google Storage fixtures for testing * Fix Google Storage mock bucket copy_blob method * Change get_bucket method to bucket for GSClient * Update test mocks for Google Storage * Add documentation for Google Storage * Expand authentication options * Update metadata fetcher for GSPath * Add Google Cloud setup action to CI workflow * Tweaks for tests to work on Windows Co-authored-by: Macklan Weinstein <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google Cloud Storage support with
GSClientandGSPathsubclasses.Features:
GSClientandGSPathas subclasses ofClientandCloudPathrespectively.gsas an extra for pip installation with separate requirements.txt.gs_rigtest configuration and adds torigfor test suite.GSClientandGSPathwithout internet.GSClientandGSPathspecific features.gsis a pip extra for Google Cloud Storage support.The GitHub Actions
testsworkflow has been updated to includeGOOGLE_APPLICATION_CREDENTIALSandLIVE_GS_BUCKETenvironment variables for GitHub Secrets usage. However, it seems, from the Google Service Account Authentication documentation, that authentication cannot happen with credentials in environment variables directly. Rather the environment variableGOOGLE_APPLICATION_CREDENTIALSmust point to a JSON file with the authentication credentials. I don't know of a secure way to resolve this issue with GitHub Secrets.Resolves #25.