-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LocalPath implementations and documentation for test mocking #107
Conversation
Codecov Report
@@ Coverage Diff @@
## master #107 +/- ##
=======================================
Coverage 91.5% 91.5%
=======================================
Files 11 18 +7
Lines 839 1034 +195
=======================================
+ Hits 768 947 +179
- Misses 71 87 +16
|
@pjbull I think this is ready for review! |
@pjbull I rebased this PR and added support for the new GS classes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Would be good to add a bullet to "why cloudpathlib" at the top of the readme that says something like "Testability: We provide Local*
classes that can be used to easily mock cloud storage in your unit tests."
LocalPath
andLocalClient
that use the local filesystem as "cloud" storage.LocalAzureBlobClient
,LocalAzureBlobPath
,LocalS3Client
,LocalS3Path
that are intended to be monkeypatch substitutes for testing (UPDATE: +LocalGSClient
,LocalGSPath
)"Testing with cloudpathlib""Testing code that uses cloudpathlib" with examples of how to patch things for testsResolves #106