Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getPreviousTitle always returns the previous title independent of the tab history #1076

Closed
ch-weiss opened this issue Apr 7, 2014 · 5 comments

Comments

@ch-weiss
Copy link

ch-weiss commented Apr 7, 2014

In beta 1 getPreviousTitle() of $ionicNavBarDelegate always returns the previous title independent of the tab history of each tab. Example to reproduce the issue:

  1. Choose tab A.
  2. Navigate to a subpage of tab A. The correct previous title of the page before of tab A is shown.
  3. Choose tab B.
  4. Navigage to a subpage of tab B.The correct previous title of the page before of tab B is shown.
  5. Choose tab A again. Now it shows the previous title of the page before of tab B (step 4) instead of the previous title of the page before of tab A (step 2).
@ajoslin
Copy link
Contributor

ajoslin commented Apr 8, 2014

Good catch! Will have to think about how to fix this

@ajoslin ajoslin closed this as completed in 933a555 Apr 8, 2014
@ajoslin
Copy link
Contributor

ajoslin commented Apr 8, 2014

OK, I instead made it so the navBarDelegate allows you to detect if you should use the getPreviousTitle() method; read the commit notes above for how you would do this. Use the nightly build and it will work.

@ch-weiss
Copy link
Author

ch-weiss commented Apr 8, 2014

Thank you. Good move!

@ch-weiss
Copy link
Author

ch-weiss commented Apr 9, 2014

I tried it with the nightly build and it is working fine 👍

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 6, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants