fix(ionSideMenu): use manual transclude instead of ngTransclude

Fixes #666
ionic-team · Feb 24, 2014 · 991d3cf · 991d3cf
1 parent 17e335e
commit 991d3cf
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/js/ext/angular/src/directive/ionicSideMenu.js b/js/ext/angular/src/directive/ionicSideMenu.js
@@ -153,7 +153,7 @@ angular.module('ionic.ui.sideMenu', ['ionic.service.gesture', 'ionic.service.vie
     replace: true,
     transclude: true,
     scope: true,
-    template: '<div class="menu menu-{{side}}" ng-transclude></div>',
+    template: '<div class="menu menu-{{side}}"></div>',
     compile: function(element, attr, transclude) {
       angular.isUndefined(attr.isEnabled) && attr.$set('isEnabled', 'true');
       angular.isUndefined(attr.width) && attr.$set('width', '275');
@@ -176,6 +176,10 @@ angular.module('ionic.ui.sideMenu', ['ionic.service.gesture', 'ionic.service.vie
         $scope.$watch($attr.isEnabled, function(val) {
           sideMenu.setIsEnabled(!!val);
         });
+
+        transclude($scope, function(clone) {
+          $element.append(clone);
+        });
       };
     }
   };

diff --git a/js/ext/angular/test/sideMenu.html b/js/ext/angular/test/sideMenu.html
@@ -23,11 +23,12 @@ <h1 class="title">Slide me</h1>
             <h1>Content</h1>
           </ion-content>
         </ion-pane>
-        <ion-side-menu side="left" width="$root.menuWidth || 200">
+        <ion-side-menu side="left" width="$root.menuWidth || 200" ng-controller="LeftCtrl">
           <header class="bar bar-header bar-assertive">
             <h1 class="title">Left</h1>
           </header>
           <ion-content has-header="true">
+            <h3>value = {{value}}</h3>
             <ul class="list">
               <a href="#" class="item" ng-repeat="item in list">
                 {{item.text}}
@@ -62,6 +63,10 @@ <h1 class="title">Right</h1>
         $scope.openLeft = function() {
           $ionicSideMenuDelegate.toggleLeft($scope);
         };
+      })
+      .controller('LeftCtrl', function($scope) {
+        $scope.value = true;
+        $scope.list = [{text:1},{text:2},{text:3}];
       });
     </script>
   </body>