Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V0.9.25 and <ion-side-menu data-ng-controller="xxx" > #666

Closed
abarriere opened this issue Feb 23, 2014 · 3 comments
Closed

V0.9.25 and <ion-side-menu data-ng-controller="xxx" > #666

abarriere opened this issue Feb 23, 2014 · 3 comments
Milestone

Comments

@abarriere
Copy link

Hi
in new version 0.9.25, you can't call specifique controller in ion directive

my old code was :

<side-menu side="left"  data-ng-controller="NavbarController">
<ul data-ng-show="isLoggedIn" class="list">

With 0.9.25 the data-ng-show doesnt work.

I bypass the issue by adding a div to specify controler used

<ion-side-menu >
     <div data-ng-controller="NavbarController">
       <ul data-ng-show="isLoggedIn" class="list">

ps : sorry for html, it was sanitize

@adamdbradley
Copy link
Contributor

Thanks for pointing that out, we'll take a look.

@ajoslin
Copy link
Contributor

ajoslin commented Feb 24, 2014

Thanks @abarriere!

My bad, I had changed it to use ng-transclude instead of manual transclude.

Added a test for this as well so it won't happen again.

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 6, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants