-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix stack overflow #420
Fix stack overflow #420
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought that was the most logical place to "break the loop" too, but was concerned about the potential consequences since TagDescriptor
is such a "generic class".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The String return values in TagDescriptor.getLightSourceDescription and ExifDescriptorBase.getWhiteBalanceDescription are close but not identical. Should probably decide which set to use.
Eventually, the ones in TagDescriptor will go away if PanasonicRawWbInfo2.GetWbTypeDescription is reviewed. I personally think the ones in TagDescriptor are mildly better.
heh - scratch all of that comment. I should read all the commits since you already made the choice in the last one. It's still true that PanasonicRawWbInfo2.GetWbTypeDescription could probably get the same treatment and then getLightSourceDescription can be removed entirely. metadata-extractor/Source/com/drew/metadata/exif/PanasonicRawWbInfo2Descriptor.java Line 56 in 1f15c79
|
Thanks! I completely missed that. |
5cfbc5d
to
405875d
Compare
mis-click on the review thing. sorry -- getting sloppy |
No worries :) |
Fixes #419.