Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stack overflow #420

Merged
merged 3 commits into from
Jul 24, 2019
Merged

Fix stack overflow #420

merged 3 commits into from
Jul 24, 2019

Conversation

drewnoakes
Copy link
Owner

Fixes #419.

@drewnoakes drewnoakes requested a review from kwhopper July 23, 2019 09:43
Copy link
Contributor

@Nadahar Nadahar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought that was the most logical place to "break the loop" too, but was concerned about the potential consequences since TagDescriptor is such a "generic class".

Copy link
Collaborator

@kwhopper kwhopper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The String return values in TagDescriptor.getLightSourceDescription and ExifDescriptorBase.getWhiteBalanceDescription are close but not identical. Should probably decide which set to use.

Eventually, the ones in TagDescriptor will go away if PanasonicRawWbInfo2.GetWbTypeDescription is reviewed. I personally think the ones in TagDescriptor are mildly better.

@kwhopper
Copy link
Collaborator

kwhopper commented Jul 23, 2019

heh - scratch all of that comment. I should read all the commits since you already made the choice in the last one.

It's still true that PanasonicRawWbInfo2.GetWbTypeDescription could probably get the same treatment and then getLightSourceDescription can be removed entirely.

@drewnoakes
Copy link
Owner Author

getLightSourceDescription can be removed entirely

Thanks! I completely missed that.

@drewnoakes drewnoakes force-pushed the fix-issue-419-stack-overflow branch from 5cfbc5d to 405875d Compare July 24, 2019 00:07
@drewnoakes drewnoakes merged commit f866af5 into master Jul 24, 2019
@drewnoakes drewnoakes deleted the fix-issue-419-stack-overflow branch July 24, 2019 00:35
@kwhopper kwhopper self-requested a review July 24, 2019 01:57
@kwhopper
Copy link
Collaborator

mis-click on the review thing. sorry -- getting sloppy

@drewnoakes
Copy link
Owner Author

No worries :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PanasonicRawWbInfo2Descriptor: Infinite recursion extracting light source
3 participants