Fix for "Auto" noise reduction setting #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Olympus cameras with the "Auto" noise reduction setting (bit 3 set) causes this code to crash with an IndexOutOfBoundsException.
I've now added support for bit 3 ("Auto") and made the code fault tolerant if future bits are added.
Reference: https://sno.phy.queensu.ca/~phil/exiftool/TagNames/Olympus.html
|
Thanks David. I'll add the image to the sample library too. |
drewnoakes
added a commit
to drewnoakes/metadata-extractor-images
that referenced
this pull request
Apr 15, 2018
Nadahar
pushed a commit
to Nadahar/metadata-extractor-images
that referenced
this pull request
Oct 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Olympus cameras with the "Auto" noise reduction setting (bit 3 set) causes this code to crash with an IndexOutOfBoundsException.
I've now added support for bit 3 ("Auto") and made the code fault tolerant if future bits are added.
Reference: https://sno.phy.queensu.ca/~phil/exiftool/TagNames/Olympus.html
I add a sample image so you can reproduce the bug and verify the fix I made too.
