Fix invalid strong name signature caused by PublicSign on non-Windows builds#467
Merged
drewnoakes merged 2 commits intomainfrom Apr 8, 2026
Merged
Conversation
Agent-Logs-Url: https://github.com/drewnoakes/metadata-extractor-dotnet/sessions/6ce4c8d1-723c-4d0b-921b-27dad9d05b9a Co-authored-by: drewnoakes <350947+drewnoakes@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix missing valid strong name for MetadataExtractor.dll
Fix invalid strong name signature caused by PublicSign on non-Windows builds
Apr 8, 2026
drewnoakes
approved these changes
Apr 8, 2026
This was referenced Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since v2.9.1,
MetadataExtractor.dllhas shipped with an invalid strong name signature, breaking GAC deployment and strongly-signed host assemblies.sn.exe -vfails;[AssemblyName]::GetAssemblyName()returns no public key token.Root cause
The project had:
The NuGet release workflows run on
ubuntu-latest, soPublicSign=true— which embeds the public key token but replaces the actual RSA signature with zeros.sn.exe -Tstill reports the token, butsn.exe -vfails because there's no real signature.Fix
Remove the
PublicSigncondition.MetadataExtractor.snkis a full RSA key pair (PRIVATEKEYBLOB, magic0702), so the .NET SDK performs real strong name signing on Linux without any workaround needed.