Skip to content

Fix compile errors #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
drewnoakes merged 2 commits into from
May 22, 2025
Merged

Fix compile errors #442

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
733ede7
Fix compile error
drewnoakes May 22, 2025
0585e57
Reduce allocations in MOV ilst reading
drewnoakes May 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion MetadataExtractor/Formats/QuickTime/QuickTimeMetadataReader.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ void MetaDataHandler(AtomCallbackArgs a)
1 => new StringValue(data, Encoding.UTF8),

// BE Float32 (used for User Rating)
23 => BitConverter.ToSingle(BitConverter.IsLittleEndian ? data.Reverse().ToArray() : data, 0),
23 => BitConverter.ToSingle(BitConverter.IsLittleEndian ? Reversed(data) : data, 0),

// 13 JPEG
// 14 PNG
Expand All @@ -220,6 +220,12 @@ void MetaDataHandler(AtomCallbackArgs a)
};

GetMetaHeaderDirectory().Set(tag, value);

static byte[] Reversed(byte[] data)
{
Array.Reverse(data);
return data;
}
}
else
{
Expand Down
2 changes: 1 addition & 1 deletion MetadataExtractor/Formats/Tiff/TiffReader.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,7 +419,7 @@ private static void ProcessTag(ITiffHandler handler, int tagId, in int valueOffs
else
{
var array = new sbyte[componentCount];
var bytes = MemoryMarshal.Cast<sbyte, byte>(array);
var bytes = MemoryMarshal.Cast<sbyte, byte>(array.AsSpan());
reader.GetBytes(valueOffset, bytes);
handler.SetInt8SArray(tagId, array);
}
Expand Down
Loading