Skip to content

Fix a bounds check in ICC tag decoding #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
drewnoakes merged 1 commit into from
May 22, 2025
Merged

Fix a bounds check in ICC tag decoding #440

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions MetadataExtractor/Formats/Icc/IccDescriptor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,10 +72,10 @@ private enum IccTagType
{
var stringLength = reader.GetInt32(8);

if (stringLength < 0 || stringLength > bytes.Length)
if (stringLength < 0 || stringLength > bytes.Length - 12)
return null;

return Encoding.UTF8.GetString(bytes, 12, stringLength - 1);
return Encoding.UTF8.GetString(bytes, index: 12, count: stringLength - 1);
}

case IccTagType.Sig:
Expand Down
Loading