Skip to content

QuickTime: Fix parsing of the GPS tag (xyz) #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
drewnoakes merged 2 commits into from
May 25, 2025
Merged

QuickTime: Fix parsing of the GPS tag (xyz) #433

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3068547
QuickTime: Fix parsing of the GPS tag (xyz)
KirkLandTrip Feb 9, 2025
6be94e9
Merge remote-tracking branch 'origin/main' into pr-433
drewnoakes May 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions MetadataExtractor/Formats/QuickTime/QuickTimeMetadataReader.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,9 +122,9 @@ void UuidHandler(AtomCallbackArgs a)

void UserDataHandler(AtomCallbackArgs a)
{
switch (a.TypeString)
switch (a.Type)
{
case "?xyz":
case 0xa978797a: // "?xyz" (with a copyright symbol)
var stringSize = a.Reader.GetUInt16();
a.Reader.Skip(2); // uint16 language code
var stringBytes = a.Reader.GetBytes(stringSize);
Expand All @@ -134,7 +134,7 @@ void UserDataHandler(AtomCallbackArgs a)
QuickTimeMetadataHeaderDirectory.TagGpsLocation,
new StringValue(stringBytes, Encoding.UTF8));
break;
case "XMP_":
case 0x584D505F: // "XMP_" (XMP metadata)
var xmpBytes = a.Reader.GetNullTerminatedBytes((int)a.BytesLeft);
var xmpDirectory = new XmpReader().Extract(xmpBytes);
directories.Add(xmpDirectory);
Expand Down