-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: HEIF/HEIC/Apple support #231
Comments
@payton implemented HEIF/HEIC support in the Java version of this library a while ago. It shouldn't be too hard to port that implementation to .NET. drewnoakes/metadata-extractor#314 @billbris would you like to do this? |
Let me take a peek before I commit (no pun intended). |
Port of Java drewnoakes#231: Implement Huffman Tables directory and reader
Hi! First of all, congratulations on this package, it's wonderful! If nobody has started to do it, I could try it :) Thanks in advance for the answer! |
@kastwey you're most welcome to port the HEIF/HEIC support from the Java implementation to this library. The contribution would be really appreciated. Your project sounds really interesting too. I'd like to hear more about it. Will you open source it? |
Hi! Perfect, I already ported all existing heif code (I think) but I've realized that the Exif and XMP support still needs to be implemented, so I'll see if I can add it (although the ISO documentation is crazy). I'll try to do the PR during the week. Regarding the project, yes, it will be open source. The initial interface will probably be a disaster (I'm blind too so if something gets out of place or overlaps I'll need help from someone who can see ;) ), but it will be functional :) Thanks! |
Great to hear you've made progress on this already. It'll be a good addition to the library as HEIC gains traction. My early education was in a school where most of the students were blind or partially sighted. I often wonder what opportunities technology has brought to visually impaired folks, beyond the clunky mechanical Braille typewriters of the early 80's. I'll be happy to help your project however I can. |
Hi!
You can't even imagine what technology has meant to us.
I went from a Braille typewriter (perkings), to "spoken an small
specific computer (called Braille'n speak), and from there to a laptop
with a screen reader.
From there, it's been all about technology.
Now I'm working as a team leader in a multinational, and all thanks to
the technology I use is accessible. It's just wonderful.
If you like, here's a video I shot at a Microsoft MVP event talking
about current technology for blind people.
My English was terrible, but I think it's pretty much understood :)
https://channel9.msdn.com/Events/Microsoft-Spain-Events/MVP-Summit-2017-Spain/How-to-use-accessible-tools-in-the-IT-Industry
2020-01-13 15:04 GMT+01:00, Drew Noakes <[email protected]>:
… Great to hear you've made progress on this already. It'll be a good addition
to the library as HEIC gains traction.
My early education was in a school where most of the students were blind or
partially sighted. I often wonder what opportunities technology has brought
to visually impaired folks, beyond the clunky mechanical Braille typewriters
of the early 80's. I'll be happy to help your project however I can.
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#231 (comment)
|
First of all, the library is great, thanks @drewnoakes and everyone who has contributed to it :) |
This is a great library, and I would love to help. I am about 60% of the way to a Heic parser that works so far. I am working on it on my own fork at (https://github.com/DrJohnMelville/metadata-extractor-dotnet) although it looks like I forgot to push my commits to the server, so you cannot see any of my work right now, (I have just about all of the Heic container format done, which requires referencing 4 or 5 differnt places on the internet because its not all written down in one place. Once I get that done I need to map the hierarchical tree of the Heic metadata into onto the tag/value format for metadata-extractor. Any this has been a really fun project to work on. When I have something that actually works (probably in a week or two) I will try and figure out how to submit a pull request, |
Support for HEIF/HEIC has been added in #249 by @DrJohnMelville 🎉 @billbris @kastwey @mzervos would you (or anyone else) test out the code on I'd like to get this released in 2.4.0 soon. |
I tested the code with a bunch of my images (both .heic & .jpeg) and didn't observe any problems - however I was only reading the geotag, no other metadata. |
I am actually unsure regarding the licenses of the examples above, so I geotagged the heic images already present in the repo: |
Looks like a bug in the implementation here, rather than the tool that generated the files. Caught because the Exif data was at the end of the file. The fix is on |
Awesome, now it works! |
Version 2.4.0 is now available with HEIC support. Thanks everyone! |
Dear all, |
@dasunmax89 can you please open a new issue and attach an image that contains the data, so that we can investigate on an actual image? Do you have an image you can donate (publicly) to the project for analysis and regression testing? |
1: Love the product. It just worked! Refreshing.
2: I would like to get at the metadata for my HEIC files from iPhone.
3: Using BitmapMetadata in System.Windows.Media.Imaging I am able to open my .JPEG's and .HEIC's and get at the metadata. Your package is much more mature and full-featured. Have you considered the HEIC/Apple problem space? If so, I'm curious as to why it is not included (am I missing something).
It just seems that the HEIC/HEIF format will be doing nothing but growing.
I am curious as to your thoughts.
Also, love the product.
The text was updated successfully, but these errors were encountered: