fix: links not working when cloned with https #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewdeponte
reviewed
Aug 14, 2023
| private func repositoryURL() -> URL? { | ||
| if let urlString = try? self.git.findRespoitoryOriginURL()?.absoluteString { | ||
| return URL(string: urlString.replacingOccurrences(of: ":", with: "/").replacingOccurrences(of: "git@", with: "https://")) | ||
| return URL(string: urlString) |
Owner
There was a problem hiding this comment.
I would have to go back and understand why we were doing the replacing above before. But assuming it actually needed to be there for some reason. Wouldn't this change break that use case?
Seems like we need need some sort of conditional based handling of this to handle both scenarios.
Or am I missing something?
Author
There was a problem hiding this comment.
I guess a refactoring was done and this method was forgotten to be changed. I have tried to solve the problem by modifying the code as little as possible, but perhaps, as you say, it would be necessary to see the intentionality of the change that caused the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52