Keep chunked fetch Lucene I/O on search threads#1
Closed
drempapis wants to merge 4 commits intoserialize_hits_in_doc_id_orderfrom
Closed
Keep chunked fetch Lucene I/O on search threads#1drempapis wants to merge 4 commits intoserialize_hits_in_doc_id_orderfrom
drempapis wants to merge 4 commits intoserialize_hits_in_doc_id_orderfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes elastic#144467
In elastic#139124, an earlier attempt to use
ThrottledIteratorwith an executor (so chunk processing could continue on different threads while preserving strict sequencing) hit Lucene thread-affinity assertions such asBecause of that,
StreamingFetchPhaseDocsIteratorwas implemented to perform all Lucene I/O (document fetch + serialization) on the calling thread, whileThrottledTaskRunnerwithDIRECT_EXECUTOR_SERVICEwas used only to throttle asynchronous network sends.After revisiting the design, we can reintroduce
ThrottledIteratorfor sequencing/backpressure by re-acquiring per-leaf readers at each chunk boundary viasetNextReader(). This ensures that if chunk production moves between search threads, Lucene objects are acquired and consumed on the same thread for each chunk.The changes in the pr also prevent
Lucene I/Ofrom running on transport threads during ACK-driven continuation.ThrottledIterator#onItemRelease()now dispatchesrun()to a provided search executor, so chunk fetch/serialization stays on search-related threads.Dispatch is only performed when there is actual work to do, avoiding unnecessary scheduling in no-op cases.