GH-37608: [C++][Gandiva] TO_DATE function supports YYYY-MM and YYYY (… #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…YYYY (apache#37609) Added fix for case when pattern does not contain day part ### Rationale for this change TO_DATE Gandiva function returns wrong result if used with pattern 'YYYY-MM' or 'YYYY'. ### What changes are included in this PR? Add a fix for case when tm_mday is zero to set it to 1 ### Are these changes tested? Added tests that cover described cases ### Are there any user-facing changes? No * Closes: apache#37608 Authored-by: DenisTarasyuk <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
|
❌ GitHub issue apache#37608 could not be retrieved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…apache#37609)
Added fix for case when pattern does not contain day part
Rationale for this change
TO_DATE Gandiva function returns wrong result if used with pattern 'YYYY-MM' or 'YYYY'.
What changes are included in this PR?
Add a fix for case when tm_mday is zero to set it to 1
Are these changes tested?
Added tests that cover described cases
Are there any user-facing changes?
No
Authored-by: DenisTarasyuk [email protected]