Skip to content

Conversation

@xxlaykxx
Copy link

In dremio signature for substring/substr java function was changed in scope https://gerrit.drem.io/gerrit/c/dremio/+/51411 (ecause unnecessary casting from BigInt to Int). After this changes start use java function instead of gandiva and we have 2 sec regression.

After investigation of gandiva impl for this function, I found that here casting from int64 to int32 also present - so for consistency with java, signature for this function was also changed to int32. And Dremio will back to use this function again.

@github-actions
Copy link

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

1 participant