Skip to content

DX-8267: Expose the ability to set last set value #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
siddharthteotia wants to merge 3 commits into from
Closed

DX-8267: Expose the ability to set last set value #1

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9d8bb46
DX-8267: Expose the ability to set last set value
siddharthteotia Jul 18, 2017
a07cd69
DX-8267: Expose the ability to set last set value
siddharthteotia Jul 18, 2017
4629f81
DX-8267: expose the ability to set last set value count
siddharthteotia Jul 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,4 +26,5 @@
MANIFEST

cpp/.idea/
python/.eggs/
python/.eggs/
.idea/
13 changes: 13 additions & 0 deletions java/vector/src/main/java/org/apache/arrow/vector/BaseDataValueVector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@

import java.util.ArrayList;
import java.util.List;
import java.lang.reflect.Field;

import org.apache.arrow.memory.BufferAllocator;
import org.apache.arrow.vector.schema.ArrowFieldNode;
Expand All @@ -27,6 +28,8 @@
import org.apache.arrow.vector.util.CallBack;
import org.apache.arrow.vector.util.TransferPair;

import com.google.common.base.Throwables;


public abstract class BaseDataValueVector extends BaseValueVector implements BufferBacked {

Expand Down Expand Up @@ -140,4 +143,14 @@ public ArrowBuf unLoad() {
* the value vector. The purpose is to move the value vector to a "mutate" state
*/
public void reset() {}

public void setLastSet(int value) {
try {
Field f = this.getMutator().getClass().getDeclaredField("lastSet");
Copy link

@jacques-n jacques-n Jul 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should avoid reflection here and below. Implement methods directly.

f.setAccessible(true);
f.set(this.getMutator(), value);
} catch (Exception ex) {
throw Throwables.propagate(ex);
}
}
}
6 changes: 6 additions & 0 deletions java/vector/src/main/java/org/apache/arrow/vector/BaseValueVector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,5 +116,11 @@ public static boolean checkBufRefs(final ValueVector vv) {
public BufferAllocator getAllocator() {
return allocator;
}

/**
* Sets the last number of values stored in this vector to the given value count
* @param value the last count to set
*/
public abstract void setLastSet(int value);
}

11 changes: 11 additions & 0 deletions java/vector/src/main/java/org/apache/arrow/vector/complex/FixedSizeListVector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
import java.util.List;
import java.util.Objects;

import com.google.common.base.Throwables;
import com.google.common.base.Preconditions;
import com.google.common.collect.ImmutableList;
import com.google.common.collect.ObjectArrays;
Expand Down Expand Up @@ -401,4 +402,14 @@ public void copyValueSafe(int from, int to) {
}
}
}

public void setLastSet(int value) {
try {
java.lang.reflect.Field f = this.getMutator().getClass().getDeclaredField("lastSet");
f.setAccessible(true);
f.set(this.getMutator(), value);
} catch (Exception ex) {
throw Throwables.propagate(ex);
}
}
}
10 changes: 10 additions & 0 deletions java/vector/src/main/java/org/apache/arrow/vector/complex/ListVector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
import java.util.Collections;
import java.util.List;

import com.google.common.base.Throwables;
import com.google.common.collect.ImmutableList;
import com.google.common.collect.ObjectArrays;

Expand Down Expand Up @@ -411,4 +412,13 @@ public void setValueCount(int valueCount) {
}
}

public void setLastSet(int value) {
try {
java.lang.reflect.Field f = this.getMutator().getClass().getDeclaredField("lastSet");
f.setAccessible(true);
f.set(this.getMutator(), value);
} catch (Exception ex) {
throw Throwables.propagate(ex);
}
}
}