Fix caching #79
Fix caching #79
Conversation
…rs who are not allowed to add pages
| @@ -83,7 +83,8 @@ public function render($mode, Doku_Renderer $renderer, $data) { | |||
| global $lang; | |||
|
|
|||
| if($mode == 'xhtml') { | |||
| $disablecache = null; | |||
| $disablecache = true; | |||
| if($disablecache) $renderer->info['cache'] = false; | |||
| $namespaceinput = $this->_htmlNamespaceInput($data['namespace'], $disablecache); | |||
There was a problem hiding this comment.
Please note, there was some decision making in the _htmlNamespaceInput() method, which modifies $disablecache by reference.
There was a problem hiding this comment.
Damn, I failed to consider that, thanks for the heads up @Klap-in.
So in fact this change is not only useless, but also harmful because $renderer->info['cache'] will no longer be set correctly.
I'll revert.
This reverts commit 52cbbe7. As @Klap-in pointed out [1] this change was incorrect as $disablecache is passed by reference and updated by _htmlNamespaceInput(). Conflicts: syntax.php [1]: #79 (comment)
|
@Klap-in I've been looking into this some more, and to be honest I can't think of any way to fix the caching the problem, other than always calling Of course, that makes the code you added in _htmlNamespaceInput() with the $disablecache byref parameter useless, and that should be cleaned up. I know it was a long time ago that you contributed that (716e610 was committed in march 2014), but before I make any changes, maybe you remember and can share some insight as to why you decided to only selectively disable the cache that way, vs doing it systematically. As a side note, I also read the Dokuwiki documentation on caching, and to be honest I find it a bit difficult to understand. In particular, I am confused with the recommended usage of the PARSER_CACHE_USE event, i.e. how it should be implemented and why... Since you authored that doc, Maybe you can offer some advice or point me to some examples. Thanks in advance for your help ! |
|
In general you like to have caching to speed up the loading of a page. It is especially useful for pages that are bigger and and show often. If it becomes ACL dependent we can consider different things, e.g. creating caches per group or per user (you modify then the key e.g. the indexmenu is doing that, disadvantage of that solution is that you add extra configuration option), or just load this piece of information by ajax, such that it can be generated fresh everytime. EDIT (dregad): fix link to new plugin version |
|
Thanks for the feedback and the link to the tindexmenu plugin source code. At first I was very confused because it seemed like a very old, obsolete plugin, until I found the related extension page linking to a newer, maintained version ;-) I'll have a look and get back to you if I have more questions. |
|
Sorry, I meant indexmenu plugin indeed. The indexmenu plugin is receiving a overhaul of its code (see PR #254). The javascript version will switch to ajax loading of the nodes (default per one level). The fallback version and the non-javascript tree are still included in the page, and need a fine-grained cache. |
Users who can add pages have seen a cached page for users who are not allowed to add pages