Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add placeholder= to indicate field requires a page name #88

Closed
bradgillap opened this issue Sep 16, 2021 · 1 comment
Closed

Add placeholder= to indicate field requires a page name #88

bradgillap opened this issue Sep 16, 2021 · 1 comment

Comments

@bradgillap
Copy link

bradgillap commented Sep 16, 2021

Hello, thank you for the plugin.

Just a recommendation

on line 103 of syntax.php

. DOKU_TAB . DOKU_TAB . '<input class="edit" type="text" name="title" size="20" maxlength="255" tabindex="2" placeholder="Page Name" />' . DOKU_LF

Would also recommend adding some space to the form-control class but that's just nitpicking.

.form-control {
margin-bottom: 1em;
}

fancy

image

@dregad
Copy link
Owner

dregad commented Sep 14, 2024

Would also recommend adding some space to the form-control class but that's just nitpicking.

.form-control {
margin-bottom: 1em;
}

I'm not sure where this form-control class is coming from - it is not part of the markup generated by the plugin.

I tried adding the proposed 1em margin to the addnewpage div, but it does not seem to make any difference when the page renders (at least with the default dokuwiki template).

@dregad dregad closed this as completed in df9a92a Sep 14, 2024
dregad added a commit that referenced this issue Sep 14, 2024
- Placeholder text (#88)
- Translations
- Code cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants