Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification parsing for Canadian dollars #201

Closed
dballagi opened this issue Nov 5, 2023 · 2 comments
Closed

Notification parsing for Canadian dollars #201

dballagi opened this issue Nov 5, 2023 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@dballagi
Copy link
Contributor

dballagi commented Nov 5, 2023

Description

First of all, the notification listener works perfectly with the RBC Mobile banking app, it extracts the necessary information and populates the input fields in the add transaction view. However it selects USD by default (I reckon it's because of the $ character). It wouldn't be a big deal, I can change the currency by hand, however doing so resets the amount field, forcing me to reenter it by hand.

Proposal

I see a few easy solutions to this:

  1. allow setting the default currency when configuring an app for listening
  2. remove the input reset when the currency is changed

Screen recording

signal-2023-11-05-071135.mp4

Additionally, could you also add an optional field for the listening configuration where one could select the default expense account, not just the asset account?

@dreautall
Copy link
Owner

dreautall commented Nov 5, 2023

Hey! That the amount is deleted when you select another currency is definitely a bug that I need to fix, thank you for the report and the short video.

The general issue that $ means USD was mentioned in #111. If your notification says "C$12.34" or "12.34 CAD" it should also select the right currency. If your notification just says "$12.34", please see my reply there for a potential solution (and why I don't want to "fix" that):

The better way in my opinion would be to adapt the Firefly currencies to your needs. That means, change the currency symbol of Australian Dollars (default A$) to $, and change the US Dollar symbol (default $) for example to US$.

@dreautall dreautall self-assigned this Nov 5, 2023
@dreautall dreautall added the bug Something isn't working label Nov 5, 2023
@dreautall dreautall added this to the v1.0.0 milestone Nov 5, 2023
@dreautall dreautall moved this to Todo in Waterfly III Nov 5, 2023
@dballagi
Copy link
Contributor Author

dballagi commented Nov 5, 2023

I'll make the configuration change in Firefly, thank you!

@dreautall dreautall modified the milestones: v1.0.0, v0.3.1 Dec 28, 2023
@dreautall dreautall moved this from Todo to In Progress in Waterfly III Dec 28, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Waterfly III Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

2 participants