fix: Modified inflect() method to allow floats #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s between 1 < n <= 2 are not accidentally left singularized.
|
@p-kuen Glad to contribute! Just curious, when do you think the NPM package will update? |
|
Sorry it took so long. I just published 1.13.2 to fix this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you give the
inflect()function a float number such as1.5(or really any number between 1 < n <= 2) the string should be pluralized. Due to theparseInt(), however, the string is left singular. This fix aims to solve that issue by allowing floats and evaluating the only case where singular is used:count=1;.Example:
inflect( 'inches', 1) // 'inch'inflect( 'inches', 1.5) // 'inches'