Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use custom stream to record audio #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MargieLCS
Copy link

Hello,

This code change allows you to use your own stream when recording audio. The StartRecording function now accepts a stream object:

public async Task<Task<string>> StartRecording (Stream recordStream = null, bool writeHeaders = false)

If recordStream is null the old behavior is used where a file is written on the device. The writeHeaders flag can be used to write the WAV headers to the beginning of the stream.

Example usage:
var memoryStream = new MemoryStream();
var audioRecordTask = await recorder.StartRecording (memoryStream, true);

I added this change for my scenario where I don't want data to be stored on the device or use an internal memoryStream like NateRickard/Plugin.AudioRecorder#48.
This change will also allow scenarios mentioned in NateRickard/Plugin.AudioRecorder#12 and NateRickard/Plugin.AudioRecorder#13 by reusing the stream. It also supports the scenario of NateRickard/Plugin.AudioRecorder#48, using a memory stream instead of filestream.

@MargieLCS
Copy link
Author

@drasticactions
Hi! Have you been able to look at this pullrequest yet? It would help us a lot! Thanks in advance :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants