Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING: Remove openChannel method, open channels inside on() instead #91

Merged
merged 1 commit into from
Nov 8, 2020
Merged

BREAKING: Remove openChannel method, open channels inside on() instead #91

merged 1 commit into from
Nov 8, 2020

Conversation

ebebbington
Copy link
Member

@ebebbington ebebbington commented Oct 31, 2020 •
edited by crookse
Loading

Fixes #78

Description

  • I felt openChannel was unnecessary, so this PR removes that method and moves the logic into on() to register the channels

Other Notes

  • BREAKING CHANGE

@crookse crookse added minor and removed major labels Oct 31, 2020
@crookse
Copy link
Member

crookse commented Oct 31, 2020

changed the label to minor. although this is a breaking change and warrants a major version. we're not going to v1 yet, so let's just increment a minor version

@ebebbington
Copy link
Member Author

Oh yeah lol, I guess the next release is gonna be 1.0.0 anyway

@crookse crookse added Priority: Medium Type: Minor Merging this pull request results in a minor version increment and removed minor labels Nov 1, 2020
crookse
crookse approved these changes Nov 2, 2020
View reviewed changes
Copy link
Member

@crookse crookse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ebebbington
Copy link
Member Author

ill add the docs today

@ebebbington
Copy link
Member Author

docs added

saragee3
saragee3 approved these changes Nov 7, 2020
View reviewed changes
Copy link
Member

@saragee3 saragee3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@ebebbington
Copy link
Member Author

merging as docs have been merged

@ebebbington ebebbington merged commit ad8d578 into master Nov 8, 2020
@ebebbington ebebbington deleted the 78-remove-open-channel branch November 8, 2020 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saragee3 saragee3 saragee3 approved these changes

@crookse crookse crookse approved these changes

@Guergeiro Guergeiro Awaiting requested review from Guergeiro

Assignees
No one assigned
Labels
Type: Minor Merging this pull request results in a minor version increment
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove openChannel?
3 participants
@ebebbington @crookse @saragee3