Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Refactor wss tests #89

Merged
merged 9 commits into from
Dec 2, 2020
Merged

chore: Refactor wss tests #89

merged 9 commits into from
Dec 2, 2020

Conversation

ebebbington
Copy link
Member

@ebebbington ebebbington commented Oct 21, 2020 •
edited
Loading

Description

  • Refactors app_3001 test

@ebebbington ebebbington mentioned this pull request Oct 21, 2020
Closed
@ebebbington ebebbington marked this pull request as draft October 21, 2020 17:00
@ebebbington ebebbington linked an issue Oct 21, 2020 that may be closed by this pull request
HTTPS Integration tests not working (app_3001) #88
Closed
@ebebbington ebebbington self-assigned this Oct 21, 2020
@ebebbington ebebbington removed the chore label Oct 29, 2020
@ebebbington
Copy link
Member Author

TODO
All we need to do is create the ws server (can copy code from the test and then comment out the whole rhum code, then run with deno run), and check it works with tls. Then uncomment the tests, make the changes needed and everything should work

@crookse crookse added chore Type: Patch Merging this pull request results in a patch version increment and removed chore labels Oct 31, 2020
@ebebbington
Copy link
Member Author

Ok so this PR is ready for review, but it doesn't actually fix anything. It improves the test code a lot, and i am sick of not being to able to fix it :P So really, this PR is just an improvement. to the test code so when we do come back to it, it's easier to work with

Again, this fixes nothing, and changes nothing in the source code or the ci

@ebebbington ebebbington marked this pull request as ready for review November 26, 2020 17:11
@ebebbington ebebbington removed a link to an issue Nov 26, 2020
HTTPS Integration tests not working (app_3001) #88
Closed
@ebebbington
Copy link
Member Author

In reference to #88

Guergeiro
Guergeiro approved these changes Dec 2, 2020
View reviewed changes
Copy link
Member

@Guergeiro Guergeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing 👍🏿

@ebebbington ebebbington added Type: Chore Merging this pull request results in a patch version increment and removed Type: Patch Merging this pull request results in a patch version increment labels Dec 2, 2020
@ebebbington ebebbington changed the title chore: Fix and enable wss tests chore: Refactor wss tests Dec 2, 2020
@ebebbington ebebbington merged commit 3bef269 into master Dec 2, 2020
@ebebbington ebebbington deleted the fix-wss-tests branch December 2, 2020 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Guergeiro Guergeiro Guergeiro approved these changes

@crookse crookse crookse approved these changes

@saragee3 saragee3 Awaiting requested review from saragee3

Assignees

@ebebbington ebebbington

Labels
Type: Chore Merging this pull request results in a patch version increment
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ebebbington @crookse @Guergeiro