-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workflows / CI: updated to Rails 7 #936
Conversation
39e0a22
to
e4bcc88
Compare
e4bcc88
to
97e14fa
Compare
end | ||
gem 'mongoid' unless | ||
rails_version == 'edge' | ||
gem 'active_model_serializers' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved here to be loaded on application start.
if defined?(Mongoid) | ||
class MongoidPostDecorator < Draper::Decorator | ||
end | ||
class MongoidPostDecorator < Draper::Decorator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The file should define the class when the app is eager loaded.
1322b79
to
f9c564a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The merge-base changed after approval.
f9c564a
to
6dc30fc
Compare
@y-yagi, I'm sorry, but I had to re-push after getting conflicts (despite they have been auto-resolved). |
6dc30fc
to
356d69c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Updated _dummy_ application to Rails 7.2. Loading process has changed in Rails 7.
356d69c
to
6aefe6a
Compare
Updated dummy application to Rails 7.2.
Loading process has changed in Rails 7.
To-Dos
References