Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflows / CI: updated to Rails 7 #936

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Workflows / CI: updated to Rails 7 #936

merged 1 commit into from
Oct 4, 2024

Conversation

Alexander-Senko
Copy link
Collaborator

@Alexander-Senko Alexander-Senko commented Sep 25, 2024

Updated dummy application to Rails 7.2.
Loading process has changed in Rails 7.

To-Dos

  • tests

References

end
gem 'mongoid' unless
rails_version == 'edge'
gem 'active_model_serializers'
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved here to be loaded on application start.

if defined?(Mongoid)
class MongoidPostDecorator < Draper::Decorator
end
class MongoidPostDecorator < Draper::Decorator
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file should define the class when the app is eager loaded.

@Alexander-Senko Alexander-Senko force-pushed the fix/tests branch 2 times, most recently from 1322b79 to f9c564a Compare September 27, 2024 13:26
y-yagi
y-yagi previously approved these changes Oct 3, 2024
Copy link
Collaborator

@y-yagi y-yagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Alexander-Senko Alexander-Senko deleted the fix/tests branch October 3, 2024 23:36
@Alexander-Senko Alexander-Senko restored the fix/tests branch October 3, 2024 23:41
@Alexander-Senko Alexander-Senko dismissed y-yagi’s stale review October 3, 2024 23:44

The merge-base changed after approval.

@Alexander-Senko Alexander-Senko requested a review from y-yagi October 3, 2024 23:45
@Alexander-Senko
Copy link
Collaborator Author

@y-yagi, I'm sorry, but I had to re-push after getting conflicts (despite they have been auto-resolved).

Copy link
Collaborator

@y-yagi y-yagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Updated _dummy_ application to Rails 7.2.
Loading process has changed in Rails 7.
@Alexander-Senko Alexander-Senko merged commit 4173a0f into master Oct 4, 2024
9 checks passed
@Alexander-Senko Alexander-Senko deleted the fix/tests branch October 4, 2024 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants