Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration with Turbo::Broadcastable #929

Merged

Conversation

Alexander-Senko
Copy link
Collaborator

@Alexander-Senko Alexander-Senko commented Feb 6, 2024

Description

Overriding defaults for Turbo broadcast jobs allows one to get decorated objects in model partials by default.

Testing

  1. Broadcast an object with Turbo.
  2. Check if the local variable passed into the partial is decorated.

To-Dos

  • tests
  • documentation

References

lib/draper/decoratable.rb Outdated Show resolved Hide resolved
@Alexander-Senko Alexander-Senko removed the request for review from seanlinsley August 22, 2024 08:46
@Alexander-Senko Alexander-Senko force-pushed the turbo-broadcastable branch 4 times, most recently from 7009fc3 to 7611403 Compare August 30, 2024 06:53
@Alexander-Senko Alexander-Senko requested a review from y-yagi August 30, 2024 06:55
@Alexander-Senko Alexander-Senko added this to the 4.1 milestone Aug 31, 2024
Overriding defaults for Turbo broadcast jobs allows one to get decorated
objects in model partials by default.

Resolves drapergem#910.
Requires drapergem#928.
@Alexander-Senko Alexander-Senko modified the milestones: 4.1, 5.0 Sep 2, 2024
Copy link
Collaborator

@y-yagi y-yagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Alexander-Senko Alexander-Senko merged commit a1439ff into drapergem:master Sep 3, 2024
8 checks passed
@Alexander-Senko Alexander-Senko deleted the turbo-broadcastable branch September 3, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Usage with Turbo::Broadcastable
2 participants