Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CollectionDecorator#respond_to? for non AR collections #920

Merged

Conversation

catks
Copy link
Contributor

@catks catks commented May 18, 2022

Description

Draper::Collection#respond_to? does not work properly when using a non AR object, eg:

class FooDecorator < Draper::Decorator; end  

decorator_collection = FooDecorator.decorate_collection([Object.new])
decorator_collection.respond_to?(:limit) #=> true
decorator_collection.limit(10) # Raises NoMethodError: undefined method `limit' for []:Array   

I think decorator_collection.respond_to?(:limit) should return false for these cases

Testing

  1. Create a empty decorator with: class FooDecorator < Draper::Decorator; end
  2. Initialize a non AR collection with it: decorator_collection = FooDecorator.decorate_collection([Object.new])
  3. decorator_collection.respond_to?(:limit) should return false

To-Dos

  • tests
  • documentation

References

@catks catks marked this pull request as ready for review May 18, 2022 15:50
@Alexander-Senko Alexander-Senko force-pushed the fix-respond-to-for-non-ar-collections branch from bc5aede to 66ba1e7 Compare August 30, 2024 07:59
@Alexander-Senko Alexander-Senko merged commit 9daf3ac into drapergem:master Aug 30, 2024
8 checks passed
@Alexander-Senko Alexander-Senko added this to the 4.0.3 milestone Oct 4, 2024
Alexander-Senko added a commit that referenced this pull request Oct 4, 2024
Added support for latest Ruby (upto 3.4) and Rails (upto 8) versions.

## Fixes

* `CollectionDecorator#respond_to?` for non-ORM collections
  (#920)
* Using Draper outside of controller scope
  (#927)
* Decoration of AR associations
  (#932)

## Performance

* Sped up delegation via `delegate_all`
  (#911)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants