Add Ruby 3.1 and 3.2 to the CI matrix and fix CI failure in Ruby 3 #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since rspec-mocks v3.10.3, `with` now distinguishes between keyword args and hash in Ruby 3. See rspec/rspec-mocks#1394 for details.
net-imap, net-pop and net-smtp are bundled gems in Ruby 3.1. So they need to be listed in Gemfile. See https://www.ruby-lang.org/en/news/2021/12/25/ruby-3-1-0-released/ for details.
GitHub asks developers to define workflow permissions, see below for securing GitHub workflows against supply-chain attacks. - https://github.blog/changelog/2021-04-20-github-actions-control-permissions-for-github_token/ - https://docs.github.com/en/actions/security-guides/automatic-token-authentication#modifying-the-permissions-for-the-github_token
mishina2228
force-pushed
the
ci-ruby3-1
branch
from
403ebd0 to
3152987
Compare
|
I've added Ruby 3.2 to the CI matrix and Ruby 2.5 compatibility. |
mishina2228
changed the title
This suppresses the following warning: ``` Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: paambaati/[email protected] ```
|
@codebycliff any chance of merging this? |
|
@mishina2228 |
|
@y-yagi I added Ruby 3.3 to the matrix! Also, adjusted gem dependencies, etc. |
y-yagi
approved these changes
Aug 21, 2024
|
@mishina2228 Thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds Ruby 3.1 and 3.2 to the CI matrix, and fix CI failure in Ruby 3.
Here are the details:
Since rspec-mocks v3.10.3,
withnow distinguishes between keyword args and hash in Ruby 3.See Make
withsupport Ruby 3 keywords rspec/rspec-mocks#1394 for details.This reduces code for caching.
net-imap,net-popandnet-smtpare bundled gems in Ruby 3.1.So they need to be listed in
Gemfile.See https://www.ruby-lang.org/en/news/2021/12/25/ruby-3-1-0-released/ for details.
actions/checkoutfrom v2 to v3GitHub asks developers to define workflow permissions,
see below for securing GitHub workflows against supply-chain attacks.
https://github.com/mongodb/mongoid/blob/3e6956215f7474d90e52865d982624fdeb981a09/mongoid.gemspec#L34