Pretend to be instance_of?(source.class)

[haines]

We pretend to be a kind_of? the source class, so I think it also makes sense to pretend to be an instance_of? the same.

I only had to tweak the handle_multiple_decoration stuff, otherwise no changes were necessary (although the specs will fail on Travis until #416 goes in).

As a nice bonus, this would make this spec pass on Rails 3.0 - it doesn't at the moment because in 3.0 ActiveRecord::Base#== doesn't call super, so it doesn't hit Decoratable#==:

# activerecord/lib/active_record/base.rb#L1629
def ==(comparison_object)
  comparison_object.equal?(self) ||
    (comparison_object.instance_of?(self.class) &&
      comparison_object.id == id && !comparison_object.new_record?)
end

Compared to, on 3.2 (and similarly on 3.1),

# activerecord/lib/active_record/base.rb#L593
def ==(comparison_object)
  super ||
    comparison_object.instance_of?(self.class) &&
    id.present? &&
    comparison_object.id == id
end

[steveklabnik]

This is also super failing on Travis.

[haines]

Yeah, this is going to fail hard at the moment due to the minitest-rails update, but it'll be fine after #416.

[steveklabnik]

Re-building!

[haines]

Travis seems to be doing something slightly odd with it. I'll rebase it and see what happens!

[haines]

Hmmm, we had another round of that internal server error on an earlier build (before I fixed a goof that was giving a spurious warning, and removed the pending spec).

Since it's almost certainly unrelated to this particular PR, I think this can still go in, but I will investigate further.

[steveklabnik]

Seems legit.