-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rake commands fail if using rails 5 #681
Comments
example Gemfile
|
In test.rake Draper requires |
This bug was causing all rake tasks to fail in Rails 5 when draper gem was present Fixes drapergem#681
@audionerd do you have any plans regarding send pull request of your 'rails5' branch to the master branch of this repo? |
@asiniy No, sorry, I haven't had time to dig further into Rails 5 support for Draper. My current branch was just a quick hack that "worked for me", but I didn't do any further testing. |
can any one tell me how to resolve this error. |
@mayank-istar - Try "gem 'draper', github: 'audionerd/draper', branch: 'rails5'" |
@audionerd are you planning on opening a pull request? |
@audionerd would be great to see it get merged. |
This bug was causing all rake tasks to fail in Rails 5 when draper gem was present Fixes drapergem#681
I can't pull draper from github because I'm using it in an engine as a dependency. Are there any plans to add official Rails 5 support? |
@ivanjolic95 : Did you try gem 'draper', github: 'audionerd/draper', branch: 'rails5' ? |
I can't really use any fork because I cannot pull gems from github in engine's .gemspec file. I've tried to put it in the gemfile and it doesn't work. |
Hi, folks! |
Merge https://github.com/audionerd/draper/tree/rails5 to fix dependency on rails/test_unit/sub_test_task Fixes drapergem#681
Fix dependency on rails/test_unit/sub_test_task (drapergem#681)
Instead of using forked version of draper, you can do monkey patch like this: # lib/rails/test_unit/sub_test_task.rb
class Rails::SubTestTask < Rake::TestTask
end |
How come this is tagged as Closed and Merged when it very clearly isn't? I've just created a new Rails 5 project and get this exact error. |
My team is also receiving this error on various projects when attempting to move to Rails 5. Any progress on getting this fixed (without monkey patching)? |
@JohnSmall @kyledecot - same. Brand new Rails 5 project and just |
Guys, feel free to switch to the |
@asiniy do you mean https://github.com/MrEmelianenko/drape? It's not developed for the last 5 months, how can anyone be sure it will be maintained in the future? |
omg, that's lame. |
Still no solution for this? |
Could someone please open a PR? |
So, the issue is 1,5 years old and there is still no fix for that? Except the monkey patch and forked repos, of course... |
For Rails 5 use: Not a fork and not a monkey patch. Seems to be the "best" solution right now. |
It works with rails 5, thank you @MatthiasRMS |
Hi, same issue with gem 'rails', '~> 5.0.1' And gem 'draper' is not working for me, I try master, rails5 branch, 3.0.0.pre1 |
Is this still an issue in master? |
I believe this is no longer an issue. Please correct me if I'm wrong and I'll take a look into it. |
@codebycliff Is a new version going to be released on rubygems? |
@kyledecot Yes, soon.. I'm hoping to have a release in the next couple weeks. |
## Fixed * Ruby 2.6 (see hotwired/turbo-rails/#681). ## Changed * Moved Rails versions to CI `matrix`. * Both edge and outdated Ruby / Rails versions may fail. * Use the latest RubyGems.
## Fixed * Ruby 2.6 (see hotwired/turbo-rails/#681). ## Changed * Moved Rails versions to CI `matrix`. * Both edge and outdated Ruby / Rails versions may fail. * Use the latest RubyGems.
## Fixed * Ruby 2.6 (see hotwired/turbo-rails/#681). ## Changed * Moved Rails versions to CI `matrix`. * Both edge and outdated Ruby / Rails versions may fail. * Use the latest RubyGems.
## Fixed * Ruby 2.6 (see hotwired/turbo-rails/#681). ## Changed * Moved Rails versions to CI `matrix`. * Both edge and outdated Ruby / Rails versions may fail. * Use the latest RubyGems.
## Fixed * Ruby 2.6 (see hotwired/turbo-rails/#681). ## Changed * Moved Rails versions to CI `matrix`. * Both edge and outdated Ruby / Rails versions may fail. * Use the latest RubyGems.
## Fixed * Ruby 2.6 (see hotwired/turbo-rails/#681). ## Changed * Moved Rails versions to CI `matrix`. * Both edge and outdated Ruby / Rails versions may fail. * Use the latest RubyGems.
## Fixed * Ruby 2.6 (see hotwired/turbo-rails/#681). ## Changed * Moved Rails versions to CI `matrix`. * Both edge and outdated Ruby / Rails versions may fail. * Use the latest RubyGems.
## Fixed * Ruby 2.6 (see hotwired/turbo-rails/#681). ## Changed * Moved Rails versions to CI `matrix`. * Both edge and outdated Ruby / Rails versions may fail. * Use the latest RubyGems.
## Fixed * Ruby 2.6 (see hotwired/turbo-rails/#681). ## Changed * Moved Rails versions to CI `matrix`. * Both edge and outdated Ruby / Rails versions may fail. * Use the latest RubyGems.
## Fixed * Ruby 2.6 (see hotwired/turbo-rails/#681). ## Changed * Moved Rails versions to CI `matrix`. * Both edge and outdated Ruby / Rails versions may fail. * Use the latest RubyGems.
## Fixed * Ruby 2.6 (see hotwired/turbo-rails/#681). ## Changed * Moved Rails versions to CI `matrix`. * Both edge and outdated Ruby / Rails versions may fail. * Use the latest RubyGems.
## Fixed * Ruby 2.6 (see hotwired/turbo-rails/#681). ## Changed * Moved Rails versions to CI `matrix`. * Both edge and outdated Ruby / Rails versions may fail. * Use the latest RubyGems.
## Fixed * Ruby 2.6 (see hotwired/turbo-rails/#681). ## Changed * Moved Rails versions to CI `matrix`. * Both edge and outdated Ruby / Rails versions may fail. * Use the latest RubyGems.
## Fixed * Ruby 2.6 (see hotwired/turbo-rails/#681). ## Changed * Moved Rails versions to CI `matrix`. * Both edge and outdated Ruby / Rails versions may fail. * Use the latest RubyGems.
## Fixed * Ruby 2.6 (see hotwired/turbo-rails/#681). ## Changed * Moved Rails versions to CI `matrix`. * Both edge and outdated Ruby / Rails versions may fail. * Use the latest RubyGems.
## Fixed * Ruby 2.6 (see hotwired/turbo-rails/#681). ## Changed * Moved Rails versions to CI `matrix`. * Both edge and outdated Ruby / Rails versions may fail. * Use the latest RubyGems.
## Fixed * Ruby 2.6 (see hotwired/turbo-rails/#681). ## Changed * Moved Rails versions to CI `matrix`. * Both edge and outdated Ruby / Rails versions may fail. * Use the latest RubyGems.
## Fixed * Ruby 2.6 (see hotwired/turbo-rails/#681). ## Changed * Moved Rails versions to CI `matrix`. * Both edge and outdated Ruby / Rails versions may fail. * Use the latest RubyGems.
The text was updated successfully, but these errors were encountered: