Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port to fd-lock 3. #200

Merged
merged 1 commit into from
Aug 18, 2021
Merged

Port to fd-lock 3. #200

merged 1 commit into from
Aug 18, 2021

Conversation

sunfishcode
Copy link
Contributor

@sunfishcode sunfishcode commented Aug 18, 2021 •
edited
Loading

What does this PR accomplish?

  • 🪣 Misc

Changes proposed by this PR:

fd-lock 3 replaces FdLock with RwLock, with an API similar to
std::sync::RwLock.

Notes to reviewer:

📜 Checklist

  • Works on the ./demo sub directory
  • Test coverage is excellent and passes
  • Documentation is thorough

@sunfishcode
Port to fd-lock 3.
ce3118e 
fd-lock 3 replaces `FdLock` with `RwLock`, with an API similar to
`std::sync::RwLock`.
drahnr
drahnr approved these changes Aug 18, 2021
View reviewed changes
Copy link
Owner

@drahnr drahnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, much appreciated!

@drahnr drahnr merged commit 57fa808 into drahnr:master Aug 18, 2021
@sunfishcode sunfishcode mentioned this pull request Aug 18, 2021
Merged
@sunfishcode sunfishcode deleted the main branch August 18, 2021 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drahnr drahnr drahnr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sunfishcode @drahnr