Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with Windows and macOS #28

Merged
merged 3 commits into from
Sep 3, 2023

Conversation

amyspark
Copy link
Sponsor Collaborator

@amyspark amyspark commented Sep 3, 2023

👋

This PR should take care of loading dylibs on macOS, linking against substrate's logger class on macOS (crunchMake needs further work here re: loader_path), and working around Meson interpreting declare_dependency variables under the hood.

@codecov
Copy link

codecov bot commented Sep 3, 2023

Codecov Report

Patch coverage has no change and project coverage change: -13.48% ⚠️

Comparison is base (9147009) 82.25% compared to head (538d06d) 68.76%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #28       +/-   ##
===========================================
- Coverage   82.25%   68.76%   -13.48%     
===========================================
  Files          21       17        -4     
  Lines        1746     1495      -251     
  Branches      517      437       -80     
===========================================
- Hits         1436     1028      -408     
+ Misses        278      244       -34     
- Partials       32      223      +191     
Files Changed Coverage Δ
crunch++/crunch++.cpp 32.34% <ø> (-15.21%) ⬇️
crunch/crunch.c 69.33% <ø> (-13.26%) ⬇️

... and 18 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@dragonmux dragonmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all LGTM, we'll check that the tests are running in CI on one of the "working" runs and merge. Thank you very much for the contribution!

@dragonmux dragonmux merged commit 538d06d into dragonmux:main Sep 3, 2023
75 of 176 checks passed
@dragonmux dragonmux temporarily deployed to github-pages September 3, 2023 02:08 — with GitHub Pages Inactive
@amyspark amyspark deleted the simplify-logger-linking branch September 3, 2023 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants