nydusify: fix the issue of blob not found when modifying image name d… #1667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ymydb
requested review from
bergwolf,
imeoer and
Desiki-high
and removed request for
a team
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1667 +/- ##
==========================================
- Coverage 60.42% 60.40% -0.02%
==========================================
Files 146 146
Lines 48943 48943
Branches 46380 46380
==========================================
- Hits 29573 29566 -7
- Misses 17906 17911 +5
- Partials 1464 1466 +2
|
…uring commit Signed-off-by: yumy <[email protected]> Signed-off-by: yumy <[email protected]>
Use `inspect_err` instead of `inspect` to to correctly handle and log errors when parsing the `failover-policy` argument. Signed-off-by: Yang Kaiyong <[email protected]> Signed-off-by: yumy <[email protected]> Signed-off-by: yumy <[email protected]>
imeoer
reviewed
Feb 26, 2025
| @@ -504,8 +504,8 @@ fn process_fs_service( | |||
| .value_of("failover-policy") | |||
| .unwrap_or(&"flush".to_string()) | |||
| .try_into() | |||
| .inspect(|_e| { | |||
| error!("Invalid failover policy"); | |||
| .inspect_err(|e| { | |||
There was a problem hiding this comment.
Thanks, please rebase the latest master, it seems have a merge op introduces the additional commit.
imeoer
reviewed
Feb 26, 2025
imeoer
reviewed
Feb 26, 2025
| logrus.Infof("copying layer %s", layer.Digest) | ||
|
|
||
| // Try to use mount API first | ||
| err := targetRemoter.Mount(ctx, layer, sourceRef) |
There was a problem hiding this comment.
Is the mount request necessary? can we just use sourceRemoter.Pull and targetRemoter.Push instead?
There was a problem hiding this comment.
Or can we use the mount hint in containerd push implementation: https://github.com/containerd/containerd/blob/f18cc4622e75b63895e9fcd616e7a5b9817fd3ac/remotes/docker/pusher.go#L174
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Issue (if applicable)
If there are Issues related to this PullRequest, please list it.
Details
There are some bugs in nydusify commit image, following bugs are fixed in this:
Use the mount blob api in the same repository
Types of changes
What types of changes does your PullRequest introduce? Put an
xin all the boxes that apply:Checklist
Go over all the following points, and put an
xin all the boxes that apply.