Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove calculate total count service #772

Merged
merged 3 commits into from
Oct 29, 2021
Merged

Conversation

gaius-qi
Copy link
Member

Description

  • Remove calculate total count service

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@gaius-qi gaius-qi added this to the v2.0.1 milestone Oct 29, 2021
@gaius-qi gaius-qi self-assigned this Oct 29, 2021
@gaius-qi gaius-qi requested a review from a team as a code owner October 29, 2021 08:08
@codecov-commenter
Copy link

Codecov Report

Merging #772 (b395e8c) into main (4aa395a) will increase coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #772      +/-   ##
==========================================
+ Coverage   37.86%   37.96%   +0.10%     
==========================================
  Files          90       90              
  Lines        6986     6986              
==========================================
+ Hits         2645     2652       +7     
+ Misses       3960     3952       -8     
- Partials      381      382       +1     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 37.96% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/peer/peertask_stream.go 56.82% <0.00%> (+2.22%) ⬆️

@lucy-cl lucy-cl merged commit 6239434 into main Oct 29, 2021
@lucy-cl lucy-cl deleted the feature/count-interface branch October 29, 2021 08:12
gaius-qi added a commit that referenced this pull request Jun 28, 2023
* feat: add user list interface

Signed-off-by: Gaius <[email protected]>

* feat: remove calculate total count interface

Signed-off-by: Gaius <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants