Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add user list interface #771

Merged
merged 1 commit into from
Oct 29, 2021
Merged

feat: add user list interface #771

merged 1 commit into from
Oct 29, 2021

Conversation

gaius-qi
Copy link
Member

Signed-off-by: Gaius [email protected]

Description

  • Add user list interface.

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@gaius-qi gaius-qi added this to the v2.0.1 milestone Oct 29, 2021
@gaius-qi gaius-qi self-assigned this Oct 29, 2021
@gaius-qi gaius-qi requested a review from a team as a code owner October 29, 2021 07:21
@codecov-commenter
Copy link

Codecov Report

Merging #771 (37a1d0c) into main (0d2ae1f) will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #771      +/-   ##
==========================================
- Coverage   37.96%   37.87%   -0.09%     
==========================================
  Files          90       90              
  Lines        6986     6986              
==========================================
- Hits         2652     2646       -6     
- Misses       3952     3960       +8     
+ Partials      382      380       -2     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 37.87% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/peer/peertask_stream.go 53.96% <0.00%> (-2.86%) ⬇️
client/daemon/peer/peertask_base.go 34.38% <0.00%> (+0.62%) ⬆️

manager/service/service.go Show resolved Hide resolved
@244372610 244372610 self-requested a review October 29, 2021 07:38
@lucy-cl lucy-cl merged commit 4aa395a into main Oct 29, 2021
@lucy-cl lucy-cl deleted the feature/user-list branch October 29, 2021 07:46
gaius-qi added a commit that referenced this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants