Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: scheduler channel blocking #756

Merged
merged 5 commits into from
Oct 27, 2021
Merged

feat: scheduler channel blocking #756

merged 5 commits into from
Oct 27, 2021

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Oct 26, 2021

Description

  • Scheduler channel blocking.

Related Issue

Fixes #749

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@gaius-qi gaius-qi requested a review from a team as a code owner October 26, 2021 14:16
@gaius-qi gaius-qi self-assigned this Oct 26, 2021
Signed-off-by: Gaius <[email protected]>
@gaius-qi gaius-qi added this to the v2.0.1 milestone Oct 26, 2021
Copy link
Contributor

@244372610 244372610 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里放在下一次调度,如果对应的conn已经关闭,再次send还是会有问题

@codecov-commenter
Copy link

Codecov Report

Merging #756 (3f568e6) into main (8f72ca8) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #756      +/-   ##
==========================================
+ Coverage   38.34%   38.39%   +0.04%     
==========================================
  Files          91       91              
  Lines        7033     7033              
==========================================
+ Hits         2697     2700       +3     
+ Misses       3953     3952       -1     
+ Partials      383      381       -2     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 38.39% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/peer/peertask_stream.go 54.92% <0.00%> (+0.31%) ⬆️
client/daemon/peer/piece_manager.go 68.89% <0.00%> (+0.78%) ⬆️

@gaius-qi gaius-qi merged commit e296e12 into main Oct 27, 2021
@gaius-qi gaius-qi deleted the fix/channel-blocking branch October 27, 2021 04:05
@jim3ma jim3ma mentioned this pull request Oct 27, 2021
gaius-qi added a commit that referenced this pull request Jun 28, 2023
* fix: scheduler channel blocking

Signed-off-by: Gaius <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Random pull failure with "500 Internal Server Error"
4 participants