Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: peer empty parent #724

Merged
merged 15 commits into from
Oct 13, 2021
Merged

fix: peer empty parent #724

merged 15 commits into from
Oct 13, 2021

Conversation

gaius-qi
Copy link
Member

Description

Related Issue

  • Fix peer empty parent.

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@gaius-qi gaius-qi added this to the v2.0.1 milestone Oct 13, 2021
@gaius-qi gaius-qi requested a review from a team as a code owner October 13, 2021 09:29
Signed-off-by: Gaius <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #724 (a4b09cb) into main (d3918ed) will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #724      +/-   ##
==========================================
- Coverage   38.56%   38.49%   -0.08%     
==========================================
  Files          89       89              
  Lines        6978     6978              
==========================================
- Hits         2691     2686       -5     
- Misses       3905     3910       +5     
  Partials      382      382              
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 38.49% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/peer/peertask_stream.go 54.60% <0.00%> (-1.59%) ⬇️

Signed-off-by: Gaius <[email protected]>
Signed-off-by: Gaius <[email protected]>
@gaius-qi gaius-qi merged commit 7d89a6c into main Oct 13, 2021
@gaius-qi gaius-qi deleted the feature/empty-parent branch October 13, 2021 10:21
@gaius-qi gaius-qi self-assigned this Oct 14, 2021
gaius-qi added a commit that referenced this pull request Jun 28, 2023
* fix: peer empty parent
Signed-off-by: Gaius <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants