Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: compatible with V1 preheat #720

Merged
merged 10 commits into from
Oct 13, 2021
Merged

feat: compatible with V1 preheat #720

merged 10 commits into from
Oct 13, 2021

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Oct 12, 2021

Description

  • Compatible with V1 preheat apis

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@gaius-qi gaius-qi requested a review from a team as a code owner October 12, 2021 11:55
@gaius-qi gaius-qi self-assigned this Oct 12, 2021
@gaius-qi gaius-qi added this to the v2.0.1 milestone Oct 12, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2021

Codecov Report

Merging #720 (3cf0e52) into main (3a301ed) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #720      +/-   ##
==========================================
- Coverage   38.63%   38.57%   -0.06%     
==========================================
  Files          89       89              
  Lines        6978     6978              
==========================================
- Hits         2696     2692       -4     
- Misses       3899     3904       +5     
+ Partials      383      382       -1     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 38.57% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/peer/peertask_stream.go 54.60% <0.00%> (-2.23%) ⬇️
client/daemon/peer/peertask_base.go 35.63% <0.00%> (+0.62%) ⬆️

@gaius-qi gaius-qi requested a review from a team as a code owner October 12, 2021 12:38
@gaius-qi gaius-qi requested a review from ansinlee October 12, 2021 12:38
@jim3ma jim3ma merged commit d3918ed into main Oct 13, 2021
@jim3ma jim3ma deleted the feature/preheat branch October 13, 2021 07:25
gaius-qi added a commit that referenced this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants