Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: client panic #719

Merged
merged 3 commits into from
Oct 13, 2021
Merged

fix: client panic #719

merged 3 commits into from
Oct 13, 2021

Conversation

jim3ma
Copy link
Member

@jim3ma jim3ma commented Oct 12, 2021 •
edited
Loading

Signed-off-by: Jim Ma [email protected]

Description

When close pt.failedPieceCh, if there is some goroutines are downloading pieces, then sends failed pieces, the client panics(recover by client).

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jim3ma
fix: client panic
bc7c343 
Signed-off-by: Jim Ma <[email protected]>
@jim3ma jim3ma requested a review from a team as a code owner October 12, 2021 08:51
gaius-qi
gaius-qi previously approved these changes Oct 12, 2021
View reviewed changes
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jim3ma jim3ma changed the title fix: client panic [WIP] fix: client panic Oct 12, 2021
yxxhero
yxxhero previously approved these changes Oct 12, 2021
View reviewed changes
Copy link
Member

@yxxhero yxxhero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jim3ma jim3ma dismissed stale reviews from yxxhero and gaius-qi via 7f74d6a October 12, 2021 13:32
@jim3ma jim3ma changed the title [WIP] fix: client panic fix: client panic Oct 12, 2021
gaius-qi
gaius-qi approved these changes Oct 13, 2021
View reviewed changes
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yxxhero
yxxhero approved these changes Oct 13, 2021
View reviewed changes
Copy link
Member

@yxxhero yxxhero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 3a301ed into main Oct 13, 2021
@gaius-qi gaius-qi deleted the fix/client-panic branch October 13, 2021 03:36
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
@jim3ma @gaius-qi
fix: client panic (#719)
77bb686 
* fix: client panic

Signed-off-by: Jim Ma <[email protected]>

* chore: update ginkgo version

Signed-off-by: Jim Ma <[email protected]>

* chore: avoid send failed piece hang

Signed-off-by: Jim Ma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaius-qi gaius-qi gaius-qi approved these changes

@yxxhero yxxhero yxxhero approved these changes

@bergwolf bergwolf Awaiting requested review from bergwolf bergwolf is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

@ansinlee ansinlee Awaiting requested review from ansinlee ansinlee is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

@yangjun289519474 yangjun289519474 Awaiting requested review from yangjun289519474 yangjun289519474 is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jim3ma @yxxhero @gaius-qi