Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support google cloud storage #3756

Merged
merged 5 commits into from
Jan 16, 2025
Merged

Conversation

jim3ma
Copy link
Member

@jim3ma jim3ma commented Jan 9, 2025

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@jim3ma jim3ma requested a review from a team as a code owner January 9, 2025 08:44
@jim3ma jim3ma force-pushed the feat/support-google-cloud-storage branch from 9700291 to 018fb57 Compare January 9, 2025 08:46
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 37.67123% with 91 lines in your changes missing coverage. Please review.

Project coverage is 35.14%. Comparing base (6c095f1) to head (77b66c2).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/source/clients/gsprotocol/gs_source_client.go 37.67% 80 Missing and 11 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3756      +/-   ##
==========================================
- Coverage   35.15%   35.14%   -0.01%     
==========================================
  Files         336      337       +1     
  Lines       37852    37998     +146     
==========================================
+ Hits        13306    13356      +50     
- Misses      23719    23802      +83     
- Partials      827      840      +13     
Flag Coverage Δ
unittests 35.14% <37.67%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/source/source_client_builder.go 0.00% <ø> (ø)
pkg/source/clients/gsprotocol/gs_source_client.go 37.67% <37.67%> (ø)

... and 3 files with indirect coverage changes

gaius-qi
gaius-qi previously approved these changes Jan 16, 2025
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

chlins
chlins previously approved these changes Jan 16, 2025
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jim3ma jim3ma dismissed stale reviews from chlins and gaius-qi via 77b66c2 January 16, 2025 11:58
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jim3ma jim3ma requested a review from xujihui1985 January 16, 2025 13:33
@jim3ma jim3ma merged commit 7f0394c into main Jan 16, 2025
27 checks passed
@jim3ma jim3ma deleted the feat/support-google-cloud-storage branch January 16, 2025 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants