feat: when the redis is disabled, AnnounceHost need to skip store redis #3712
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces several changes to ensure that the persistent cache feature is only used when Redis is enabled. The changes include adding checks for the presence of the
persistentCacheResource
before performing operations related to the persistent cache.Persistent Cache Feature Enhancements:
rdb
is not nil infunc New
inscheduler/scheduler.go
.AnnounceHost
to return early ifpersistentCacheResource
is nil, indicating that Redis is not enabled, inscheduler/service/service_v2.go
.persistentCacheResource
is nil, ensuring operations are skipped when Redis is not enabled, inscheduler/service/service_v2.go
:AnnouncePersistentCachePeer
StatPersistentCachePeer
DeletePersistentCachePeer
UploadPersistentCacheTaskStarted
UploadPersistentCacheTaskFinished
UploadPersistentCacheTaskFailed
StatPersistentCacheTask
Related Issue
Motivation and Context
Screenshots (if appropriate)
Types of changes
Checklist